https://bugs.kde.org/show_bug.cgi?id=421752

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
                   |hics/krita/commit/a5e32be94 |hics/krita/commit/988bd2018
                   |73fd50aa8a60baf3c5f0ecc0c6a |93e3f005d3d11c7adca0ba55c57
                   |3617                        |b0ba

--- Comment #4 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit 988bd201893e3f005d3d11c7adca0ba55c57b0ba by Dmitry Kazakov.
Committed on 11/06/2020 at 21:25.
Pushed by dkazakov into branch 'master'.

Fix "Stroke Selection" when any selection tool is activated

This patch is a bit hackish. The actual bug is caused by the per-tool
opacity patch (6daf2cb7), which is still planned to be refactored.

The problem is that we store opacity and the preset(!), not in the
resource server itself. Therefore, if any paint tool is first activated
when there is no preset available, then it will remember default opacity
(which was 0.0 before this patch) and all non-painting tools will use this
opacity as default.

In the future we should refactor per-tool opacity, so that it would not
write to the presets (which makes them dirty when switching tools, which
is a bug). The non-painting tools should have some flag, that would tell
the resource provider that the opacity should be stored not in the preset,
but separately.

M  +1    -1    libs/ui/kis_derived_resources.cpp

https://invent.kde.org/graphics/krita/commit/988bd201893e3f005d3d11c7adca0ba55c57b0ba

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to