https://bugs.kde.org/show_bug.cgi?id=421392
Maciej Stanczew <maciej.stancze...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |maciej.stancze...@gmail.com
--- Comment #24 from Maciej Stanczew <maciej.stancze...@gmail.com> ---
Created attachment 129169
--> https://bugs.kde.org/attachment.cgi?id=129169&action=edit
Revert to foreach in DataContainer::checkForUpdate
(In reply to Alexander Kandaurov from comment #23)
> Did a git bisect on plasma-frameworks, the breaking commit is
> 48f60533b92231c706da3c9ff0f62cff206ee8d5.
Can confirm -- after building plasma-frameworks 5.70.1 with just this commit
reverted, I can successfully open Thermal Monitor Settings without Plasma
crashing.
I did a bisect of specific changes in this commit, and found the offending one:
it's in datacontainer.cpp, in function DataContainer::checkForUpdate (line
356). I've attached a patch with just this single change reverted (and
-DQT_NO_FOREACH removed from CMakeLists), and I don't get a crash with it. If
someone could confirm that it works, it would be great.
I also tried removing qAsConst from 'for', without changing it to 'foreach',
but I still got the crash in this case. So it seems to be caused by some
difference in behavior of 'for' vs 'foreach'.
--
You are receiving this mail because:
You are watching all bug changes.
