https://bugs.kde.org/show_bug.cgi?id=331240

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/syst
                   |                            |em/dolphin/commit/0f0d14d4c
                   |                            |236eee7f1df4f0c21c60f6b784d
                   |                            |ab75

--- Comment #24 from Nate Graham <n...@kde.org> ---
Git commit 0f0d14d4c236eee7f1df4f0c21c60f6b784dab75 by Nate Graham, on behalf
of Gastón Haro.
Committed on 09/06/2020 at 17:05.
Pushed by ngraham into branch 'master'.

Provide ability to configure size cut-off for local file previews

Summary:
FileWidgets read from kdeglobals the property "MaximumSize" under
"PreviewSettings" to decide if a preview will be generated for that file.
There is no current GUI to change that file size limit. On the other hand
Dolphin ignores it.

This patch aims to fix that by adding new configuration options to Dolphin.
That is a new spinbox in Dolphin settings under General -> Previews tab.

Test Plan:
1 - Set up a local folder with 2 jpg images of less and more than 1 MB
respectively.
2 - Go to Dolphin Preferences. General -> Previews and check "JPEG Images" from
    the list. And set "Skip previews for files above:" to 1MB.
3 - Navigate to the afore mentioned folder. Only the image of size less than 1
MB should
    show a preview.

Reviewers: ngraham, #dolphin, meven, elvisangelaccio

Reviewed By: ngraham, #dolphin, meven, elvisangelaccio

Subscribers: cfeck, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D28402

M  +12   -0    src/kitemviews/kfileitemlistview.cpp
M  +11   -0    src/kitemviews/kfileitemlistview.h
M  +14   -2    src/kitemviews/kfileitemmodelrolesupdater.cpp
M  +12   -0    src/kitemviews/kfileitemmodelrolesupdater.h
M  +37   -8    src/settings/general/previewssettingspage.cpp
M  +1    -0    src/settings/general/previewssettingspage.h
M  +1    -1    src/views/dolphinitemlistview.cpp

https://invent.kde.org/system/dolphin/commit/0f0d14d4c236eee7f1df4f0c21c60f6b784dab75

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to