https://bugs.kde.org/show_bug.cgi?id=414739
Méven Car <meven....@enioka.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/grap
| |hics/spectacle/commit/dec0e
| |6cef23ac35754aa537db6d7ace4
| |2b23ca2a
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Méven Car <meven....@enioka.com> ---
Git commit dec0e6cef23ac35754aa537db6d7ace42b23ca2a by Méven Car.
Committed on 05/06/2020 at 09:10.
Pushed by meven into branch 'master'.
Refactor Spectacle to run in single instance mode with KDBusService::Unique
Summary:
Since Spectacle got DBus activation support in
09cd11881d828da35c46c48da79f2d988e6a78cc, it has been run in multiple instance
mode.
But it has been shaddowed by using qbus
ee862d161a480408338d00b8826c915f7a97575c in the desktop file to mimic singleton
behavior.
This refactors Spectacle to run in true single instance mode using
KDBusService::Unique.
This is to allow Spectacle to have its executable in its Exec desktop Entry, to
allow KWin to match the executable to the service file, itself to allow
screenshots under Wayland without intermediate click.
The listed bugs are fixed incidently except for 414739 where a simple fix was
added in screenShotUpdated.
Related: bug 420477, bug 412186
Test Plan:
Start spectacle, alternatively, from shortcut, command line.
Take screenshots, from alternative ways.
There is always at most one Spectacle window unless launched with
`--new-instance`.
Reviewers: davidre, ngraham, bport, davidedmundson, apol
Reviewed By: davidre
Subscribers: broulik, anthonyfieroni, #spectacle
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D29487
M +2 -2 desktop/org.kde.spectacle.desktop.cmake
M +30 -89 src/Main.cpp
M +170 -105 src/SpectacleCore.cpp
M +8 -10 src/SpectacleCore.h
M +5 -10 src/SpectacleDBusAdapter.cpp
M +0 -31 src/SpectacleDBusAdapter.h
https://invent.kde.org/graphics/spectacle/commit/dec0e6cef23ac35754aa537db6d7ace42b23ca2a
--
You are receiving this mail because:
You are watching all bug changes.
