https://bugs.kde.org/show_bug.cgi?id=421878
Ahmad Samir <a.samir...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://invent.kde.org/fram
| |eworks/kio/commit/576b612e0
| |d3e3f12457bc17592f696630b43
| |3188
Version Fixed In| |5.71.0
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
--- Comment #3 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit 576b612e0d3e3f12457bc17592f696630b433188 by Ahmad Samir.
Committed on 27/05/2020 at 07:09.
Pushed by dfaure into branch 'master'.
[HostInfo] Set QHostInfo::HostNotFound when a host isn't found in the DNS cache
Here is the chain, AFAIU, in order:
LocalDomainUriFilter::exists()
KUriFilterPlugin::resolveName()
KIO::HostInfo::lookupHost()
HostInfo::lookupCachedHostInfoFor()
the latter would return a default constructed QHostInfo object, calling
error() on it would return QHostInfo::NoError, which is wrong since we
didn't find that host in the KIO DNS cache.
This made the KUriFilterTest::executables unit test fail when there's
something with the connection and both the DNS lookup times out and the
host can't be found the KIO cache.
Thanks to Ben Gruber in the bug report for figuring it out. I've
verified the whole sequence by following the code via gdb.
FIXED-IN: 5.71.0
M +4 -1 src/core/hostinfo.cpp
https://invent.kde.org/frameworks/kio/commit/576b612e0d3e3f12457bc17592f696630b433188
--
You are receiving this mail because:
You are watching all bug changes.
