https://bugs.kde.org/show_bug.cgi?id=340582

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.20.0
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-workspace/commit/
                   |                            |97e843d3ead33fc8f376fe08040
                   |                            |fa1f923b831e6
         Resolution|---                         |FIXED

--- Comment #6 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit 97e843d3ead33fc8f376fe08040fa1f923b831e6 by Kai Uwe Broulik.
Committed on 18/05/2020 at 11:21.
Pushed by broulik into branch 'master'.

[Free Space Notifer] Use critical notification instead of tray icon and monitor
Root, too

This refactors the free space notifier module to use a critical (i.e.
persistent and always on top) notification for warning of low disk space.
The, albeit blinking, tray icon is easy to miss, especially when you're running
a full screen terminal, which I typically do while compiling stuff.
It now also monitors the Root folder, if it's on a separate partition from the
user's home. Furthermore, Filelight is offered to explore the drive (if
installed).

The overall warning logic remains pretty much the same:

* Once the drive goes below the configured threshold a warning notification is
shown, it stays on screen until dismissed by the user or
  when free space is above warning threshold again.
* The notification is emitted again when free space drops below half the
previous threshold, for added sense of urgency should the drive
  be rapidly filled up
* The notification is also emitted again if free space remains below the
threshold for more than one hour

(It will only emit again when it was closed, obviously, so you won't end up
with a tonne of popups after a few hours ;)

I don't think this needs to be separately configurable for Home and Root, since
the default threshold is like 200 MiB (it's not a configured
percentage), so the absolute free space it warns about will be the same, even
if your Home is giant compared to Root.
FIXED-IN: 5.20.0

Differential Revision: https://phabricator.kde.org/D29770

M  +4    -1    freespacenotifier/CMakeLists.txt
M  +76   -168  freespacenotifier/freespacenotifier.cpp
M  +23   -18   freespacenotifier/freespacenotifier.h
M  +1    -0    freespacenotifier/freespacenotifier.notifyrc
M  +62   -0    freespacenotifier/module.cpp
M  +3    -1    freespacenotifier/module.h

https://invent.kde.org/plasma/plasma-workspace/commit/97e843d3ead33fc8f376fe08040fa1f923b831e6

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to