https://bugs.kde.org/show_bug.cgi?id=421055
Ismael Asensio <isma...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kwi
| |n/db7fb26eedcac7effd908e345
| |79cf2fa422ac22b
Status|ASSIGNED |RESOLVED
Version Fixed In| |5.19.0
--- Comment #5 from Ismael Asensio <isma...@gmail.com> ---
Git commit db7fb26eedcac7effd908e34579cf2fa422ac22b by Ismael Asensio.
Committed on 15/05/2020 at 17:45.
Pushed by iasensio into branch 'Plasma/5.19'.
[kcm/kwinrules] Fix size properties not being stored
Summary:
Use `QSize`/`QPoint` to handle and store coordinate values (size and position)
Previously, the rules model stored the "coordinate" type properties as a
`QString` with format `x, y`.
This fails when setting the properties to the config schema, as it requires
a proper `QPoint` or `QSize` value, specially the latter which can't be
convert from such a string.
FIXED-IN: 5.19.0
Test Plan:
- Add a new rule and set its position and size properties
- Hitting apply stores the right values in `~\.config\kwinrulesrc`
- Close the kcm and reopen, the values are loaded
- Property detection still works for size and position
Please note that there is a pre-existing bug of some position/sizes not being
applied to the windows in some cases, when using `Apply Initially`.
Better try using the `Force` policy.
Reviewers: ngraham, #kwin, #plasma, zzag
Reviewed By: #kwin, #plasma, zzag
Subscribers: zzag, ltoscano, yurchor, kwin
Tags: #kwin
Differential Revision: https://phabricator.kde.org/D29764
M +4 -3 kcmkwin/kwinrules/package/contents/ui/RulesEditor.qml
M +7 -6 kcmkwin/kwinrules/package/contents/ui/ValueEditor.qml
M +4 -5 kcmkwin/kwinrules/ruleitem.cpp
M +2 -1 kcmkwin/kwinrules/ruleitem.h
M +6 -8 kcmkwin/kwinrules/rulesmodel.cpp
https://commits.kde.org/kwin/db7fb26eedcac7effd908e34579cf2fa422ac22b
--
You are receiving this mail because:
You are watching all bug changes.
