https://bugs.kde.org/show_bug.cgi?id=404890
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://cgit.kde.org/kio-ex |https://commits.kde.org/kio
|tras.git/commit/?id=74850eb |-extras/1df6174834bb3a126f6
|21654821a15f4a9cbdb85b75dc5 |30d4477bcdbda95f45a8b
|1a8513 |
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
Version Fixed In|20.04.0 |20.04.2
--- Comment #14 from Harald Sitter <sit...@kde.org> ---
Git commit 1df6174834bb3a126f630d4477bcdbda95f45a8b by Harald Sitter.
Committed on 14/05/2020 at 11:58.
Pushed by sitter into branch 'master'.
sftp: break large writes into multiple requests
Summary:
servers have arbitrary limits that we should stay below. to ensure this
happens use MAX_XFER_BUF_SIZE as maximum size per request. if we read
data large than that, break it apart into multiple requests
(I am mostly guessing here, the rfc doesn't seem to impose any size
constraint on the write requests themselves, so probably packet
constraints apply by default)
FIXED-IN: 20.04.2
Test Plan:
- fallocate -l 128M file
- sftp to localhost
- copy file from one dir to another
- compare checksums match
- open xls file (via kio-fuse)
- change
- save
- close
- open again
- changes are still there
Reviewers: ngraham, meven, feverfew
Reviewed By: ngraham, meven, feverfew
Subscribers: meven, feverfew, kde-frameworks-devel, kfm-devel
Tags: #dolphin, #frameworks
Differential Revision: https://phabricator.kde.org/D29634
M +57 -12 sftp/kio_sftp.cpp
M +8 -0 sftp/kio_sftp.h
https://commits.kde.org/kio-extras/1df6174834bb3a126f630d4477bcdbda95f45a8b
--
You are receiving this mail because:
You are watching all bug changes.
