https://bugs.kde.org/show_bug.cgi?id=420820
--- Comment #18 from Ahmad Samir <a.samir...@gmail.com> --- Git commit 8a282319bc9eb6dd73557319cbd59d279493cdab by Ahmad Samir. Committed on 04/05/2020 at 21:59. Pushed by ahmadsamir into branch 'master'. [KBookmarkMenu] Assign m_actionCollection early to prevent crash Summary: The deprecated ctor that took a KActionCollection param called the new ctor (that doesn't take an actionCollection before) m_actionCollection was assigned. This caused the menu actions never to get added to the actionCollection as it was still nullptr. This caused crashes in applications that still use the deprecated ctor, e.g. this bug in konsole https://bugs.kde.org/show_bug.cgi?id=420820. Since we can't assign m_actionCollection in the initializer list because then the constructor delegation would follow a member initializer (info courtsey of the compiler), introduce a helper init method to reduce code duplication between the two ctor's. Thanks to Friedrich W. H. Kossebau for figuring it out https://phabricator.kde.org/D28800#663274. Test Plan: make && ctest Reviewers: #frameworks, dfaure, kossebau, nicolasfella Reviewed By: dfaure Subscribers: rikmills, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D29427 M +14 -3 src/kbookmarkmenu.cpp M +2 -0 src/kbookmarkmenu.h https://commits.kde.org/kbookmarks/8a282319bc9eb6dd73557319cbd59d279493cdab -- You are receiving this mail because: You are watching all bug changes.
