https://bugs.kde.org/show_bug.cgi?id=218522

Igor Poboiko <igor.pobo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kjo
                   |                            |ts/bd0ea6d00f5c73bfe9c58c92
                   |                            |9db863a67b6aedb5
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5 by Igor Poboiko.
Committed on 24/04/2020 at 10:52.
Pushed by poboiko into branch 'master'.

[KJotsEdit] Fix links handling in editing mode

Summary:
When user Ctrl+Clicks on the link in the editing mode, emit the linkClicked
signal
(which is forwarded to corresponding slot inside `KJotsWidget`).

We use `mousePressEvent` instead of `mouseReleaseEvent` to be able not to move
the cursor
when user ctrl+clicks on the link (so we override default `mousePressEvent`,
which moves it)

Add visual feedback when hovering the mouse over a link with ctrl pressed
(change the cursor to pointing hand)
Add visual feedback when simply hovering the mouse over a link (a tooltip)
Related: bug 215543, bug 244846

Test Plan:
 1. Add Link, Ctrl+Click on it: mouse cursor changes, link opens
 2. Right-click on link: there is "Link" entry, which can be used to edit link
 3. Hover mouse over link: a useful tooltip appears telling user how to open it

Reviewers: dvratil

Reviewed By: dvratil

Subscribers: kde-pim

Tags: #kde_pim

Differential Revision: https://phabricator.kde.org/D29094

M  +70   -15   src/kjotsedit.cpp
M  +12   -2    src/kjotsedit.h
M  +1    -0    src/kjotswidget.cpp

https://commits.kde.org/kjots/bd0ea6d00f5c73bfe9c58c929db863a67b6aedb5

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to