https://bugs.kde.org/show_bug.cgi?id=384000
Igor Poboiko <igor.pobo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|REPORTED |RESOLVED
Latest Commit| |https://commits.kde.org/kjo
| |ts/ca6f4b963e83ed91cc7314e1
| |b60fe6607b61b53e
--- Comment #6 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit ca6f4b963e83ed91cc7314e1b60fe6607b61b53e by Igor Poboiko.
Committed on 18/04/2020 at 22:06.
Pushed by poboiko into branch 'master'.
[KJots] Fix bookmarks actions
Summary:
This patch ports KJots from deprecated `KBookmarksMenu` API (see {D25660}).
On my machine, it also fixes a crash (`bm_action` was null for some reason,
I did not investigate it though).
It also fixes the shortcuts collision (`action->setShortcut` was not enough,
one also needs to run `actionCollection->setDefaultShortcut`).
Test Plan:
1) Start KJots
2) It don't crash, and `Ambiguous shortcuts` dialog does not appear)
3) Open `Bookmarks` menu, the shortcut is `Ctrl+Shift+B`.
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: winterz, kde-pim
Tags: #kde_pim
Differential Revision: https://phabricator.kde.org/D28775
M +8 -5 src/kjotswidget.cpp
https://commits.kde.org/kjots/ca6f4b963e83ed91cc7314e1b60fe6607b61b53e
--
You are receiving this mail because:
You are watching all bug changes.
