https://bugs.kde.org/show_bug.cgi?id=256001

Igor Poboiko <igor.pobo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kte
                   |                            |xtwidgets/1d1eb6feb7f85d5e0
                   |                            |9e00f75114f671eceff1598
         Resolution|---                         |FIXED

--- Comment #2 from Igor Poboiko <igor.pobo...@gmail.com> ---
Git commit 1d1eb6feb7f85d5e09e00f75114f671eceff1598 by Igor Poboiko.
Committed on 14/04/2020 at 22:38.
Pushed by poboiko into branch 'master'.

[KRichTextEdit] Always treat key press as single modification in undo stack

Summary:
If my cursor is on a bullet list, and I press Enter to create a new element,
it registers as 5-7 actions in an undo stack, mostly margins adjustments. So to
rewind it, user has to press `Ctrl+Z` 5+ times, which is quite frustrating.

Instead this patch suggests to treat _any_ change that is a result of a single
key press as a single event, so user has to press `Ctrl+Z` just once to undo it

Test Plan:
 1) Open KMail -> New Mail, enable Rich Text mode (or, say, open KJots)
 2) Create a bullet list with couple of elements
 3) Put cursor on the last element, press Enter to create a new element
 4) Try to undo this action with Ctrl+Z
 5) (without patch) One has to press Ctrl+Z 5-7 times to undo it.
 6) (with patch) A single Ctrl+Z is enough

Reviewers: #frameworks, mlaurent, dfaure

Reviewed By: dfaure

Subscribers: ahmadsamir, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D28819

M  +2    -0    src/widgets/krichtextedit.cpp

https://commits.kde.org/ktextwidgets/1d1eb6feb7f85d5e09e00f75114f671eceff1598

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to