https://bugs.kde.org/show_bug.cgi?id=414544
Kai Uwe Broulik <k...@privat.broulik.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-browser-integration/269
| |da15cf9b48a7bac5f121c7484d1
| |42767a992d
--- Comment #2 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit 269da15cf9b48a7bac5f121c7484d142767a992d by Kai Uwe Broulik.
Committed on 13/04/2020 at 19:53.
Pushed by broulik into branch 'master'.
Provide light icon for dark mode via theme_icons
I recall we originally didn't do it when Noah added these icons as
browserAction.setIcon
wasn't able to override the icon or something like this?
However, it doesn't appear to be the case anymore in more recent versions.
While the setIcons API doesn't support theme icons, only set the custom icon
when the extension fails to start.
So let's not jeopardize the normal user experience by this edge case.
Differential Revision: https://phabricator.kde.org/D28806
M +18 -1 extension/manifest.json
https://commits.kde.org/plasma-browser-integration/269da15cf9b48a7bac5f121c7484d142767a992d
--
You are receiving this mail because:
You are watching all bug changes.
