https://bugs.kde.org/show_bug.cgi?id=417645

--- Comment #3 from Harald Sitter <sit...@kde.org> ---
Git commit 8a04e10091308ad0642e6b164e6b19f640d9aeb4 by Harald Sitter.
Committed on 25/03/2020 at 12:34.
Pushed by sitter into branch 'master'.

sftp: fix partial transfer resuming when copying to local

Summary:
the previous condition checked if the final target path size was >0,
which it would only be when the file already exists (i.e. overwrite) in
all other scenarios it would always be false and as such resuming wouldn't
work. what we actually want to check is whether the part file is >0 (i.e.
there's actual pending bytes to resume from).

this makes resuming work when copying remote->local

Test Plan:
- create file of suitably large size (1g)
- `split -b somesize` the file into two segments
- copy first segment to /tmp/file.part
- connect to /tmp over sftp and copy the file there
- progress starts at 50% and resulting file is same as input file

Reviewers: ngraham, feverfew, bruns

Subscribers: bruns, kde-frameworks-devel, kfm-devel

Tags: #dolphin, #frameworks

Differential Revision: https://phabricator.kde.org/D27872

M  +4    -2    sftp/kio_sftp.cpp

https://commits.kde.org/kio-extras/8a04e10091308ad0642e6b164e6b19f640d9aeb4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to