https://bugs.kde.org/show_bug.cgi?id=418258

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/kio
                   |                            |/14b7f2c7ee72bbf500625122a4
                   |                            |b51c81f02e421f
   Version Fixed In|                            |5.69

--- Comment #7 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit 14b7f2c7ee72bbf500625122a4b51c81f02e421f by Ahmad Samir.
Committed on 19/03/2020 at 20:37.
Pushed by ahmadsamir into branch 'master'.

[DesktopExecParser] Open {ssh,telnet,rlogin}:// urls with ktelnetservice

Summary: Extend krununittest to test ktelnetservice.

Test Plan:
$ kde-open5 ssh://user@1.1.1.1
  outputs:
  command= "ktelnetservice5 %u" args= ("ktelnetservice5 %u",
"ssh://user@1.1.1.1")
  kf5.kio.core: couldn't create slave: "klauncher said: Unknown protocol
'ssh'.\n"

and you get a message box with "File not found: ssh://user@1.1.1.1".

Apply diff then try again, now a terminal window is launched by
ktelnetservice5 and ssh is invoked as expected.

FIXED-IN: 5.69

Reviewers: #frameworks, dfaure, sitter, meven, feverfew, ngraham

Reviewed By: dfaure, feverfew, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D27999

M  +25   -0    autotests/krununittest.cpp
M  +1    -0    autotests/krununittest.h
M  +3    -0    src/core/desktopexecparser.cpp

https://commits.kde.org/kio/14b7f2c7ee72bbf500625122a4b51c81f02e421f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to