https://bugs.kde.org/show_bug.cgi?id=417281
--- Comment #8 from Julian Seward <jsew...@acm.org> --- (In reply to Andreas Arnez from comment #7) > Created attachment 126871 [details] > s390x: Fix register usage of conditional moves Looks good to me. Two minor points: For the NEVER case, it might be more "symmetrical" in relation to the ALWAYS case, to say that it modifies dst, rather than saying nothing. (I know it modifies it with the same value). Then in effect the code says: NEVER= read dst, write dst; ALWAYS = read src, write dst although I think the absolute safest thing would be to put an assertion in the construction for this insn to disallow NEVER and ALWAYS, since they are degenerate cases, and I assume will never occur in practice. Second point is .. are there any other cond-move insn variants? FP, Vector etc? +1 to land with any of the above changes you think are good (including none). -- You are receiving this mail because: You are watching all bug changes.
