https://bugs.kde.org/show_bug.cgi?id=385314
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |20.04.0
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Latest Commit| |https://commits.kde.org/gwe
| |nview/435d2ad1b250b81fed19e
| |f9b796c97d240ad4875
--- Comment #6 from Nate Graham <n...@kde.org> ---
Git commit 435d2ad1b250b81fed19ef9b796c97d240ad4875 by Nate Graham.
Committed on 17/03/2020 at 19:00.
Pushed by ngraham into branch 'release/20.04'.
Give Exit Full Screen and Configure buttons text and adjust wording
Summary:
Unlike Kate, Gwenview's {nav Exit Full Screen} button is icons-only, impeding
discoverability. This patch shows its action's text, and adjusts that text to
be more
consistent with the typical wording.
In the process, the button below it is also given visible text to avoid making
it look
odd in its layout.
To accomplish this technically, the `FullScreenToolBar` class's `addAction()`
function
is given a new optional parameter for specifying if and where the button's text
should
appear, which is then used to give the aforementioned buttons visible text
according to
the user's toolbutton text display preferences. The actions are also no longer
marked
with the Low Priority status, which forces them to be always icons-only and was
previously redundant since icons-only status was forced in a different way.
Fixed now.
FIXED-IN: 20.04.0
Test Plan: {F8176526}
Reviewers: #gwenview, #vdg, broulik
Reviewed By: broulik
Tags: #gwenview
Differential Revision: https://phabricator.kde.org/D28052
M +5 -5 app/fullscreencontent.cpp
M +1 -2 app/mainwindow.cpp
https://commits.kde.org/gwenview/435d2ad1b250b81fed19ef9b796c97d240ad4875
--
You are receiving this mail because:
You are watching all bug changes.
