https://bugs.kde.org/show_bug.cgi?id=405647

Ahmad Samir <a.samir...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://commits.kde.org/sys
                   |                            |temsettings/0be65944f311145
                   |                            |246e5c0cc2d5326d77dc4abdb
         Resolution|---                         |FIXED
   Version Fixed In|                            |5.18.1

--- Comment #3 from Ahmad Samir <a.samir...@gmail.com> ---
Git commit 0be65944f311145246e5c0cc2d5326d77dc4abdb by Ahmad Samir.
Committed on 27/02/2020 at 15:47.
Pushed by ahmadsamir into branch 'master'.

If KHelpCenter isn't available fallback to opening doc at docs.kde.org

Summary:
UrlHandler from KGUIAddons sets a handler for help:/ urls, which opens
khelpcenter if it's available or falls back to opening the relevant page
at docs.kde.org.

Explicitly add KGuiAddons to find_package() and target_link_libraries().

Depends on D27615

FIXED-IN: 5.18.1

Test Plan:
- make sure khelpcenter is not installed and open systemsettings
- navigate to any module (one that has Help visible, e.g. Fonts),
  "Help" button is disabled
- install khelpcenter and restart systemsettings, the "Help" button
  should be enabled

Reviewers: #plasma, apol

Reviewed By: apol

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27518

M  +1    -0    CMakeLists.txt
M  +1    -0    app/CMakeLists.txt
M  +5    -2    core/ModuleView.cpp

https://commits.kde.org/systemsettings/0be65944f311145246e5c0cc2d5326d77dc4abdb

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to