https://bugs.kde.org/show_bug.cgi?id=411584
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit|https://cgit.kde.org/kwin.g |https://commits.kde.org/pla
|it/commit/?id=5bec89ac90d5c |sma-desktop/1dd4668f1bf15e0
|9d72b03b60cf62bb6ef9ffb0808 |57b841ce6e538073f1538ec27
--- Comment #26 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 1dd4668f1bf15e057b841ce6e538073f1538ec27 by David Edmundson.
Committed on 24/02/2020 at 09:55.
Pushed by davidedmundson into branch 'Plasma/5.18'.
Calculate needsSave on checkbox toggle not on change
Summary:
Otherwise we will trigger it during load, which is wasteful.
But worse potentially we haven't evaluated the other settings yet, so it
could trigger that we have changed the settings, and prematurely set
apply to enabled prematurely which currently breaks things.
I suspect it will fix the bug below, I couldn't reproduce reliably
enough to prove it.
Please reopen if it remains an issue
Fixed-in: 5.18.2
Test Plan:
Opened KCM
toggling still worked as expected
Reviewers: #plasma, apol, ngraham
Reviewed By: apol, ngraham
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27590
M +1 -1 kcms/nightcolor/package/contents/ui/main.qml
https://commits.kde.org/plasma-desktop/1dd4668f1bf15e057b841ce6e538073f1538ec27
--
You are receiving this mail because:
You are watching all bug changes.
