https://bugs.kde.org/show_bug.cgi?id=417802
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kne
| |wstuff/5c7ee50bf900666efa44
| |439a4f4a12ec5df986f9
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #4 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 5c7ee50bf900666efa44439a4f4a12ec5df986f9 by David Edmundson.
Committed on 17/02/2020 at 23:31.
Pushed by davidedmundson into branch 'master'.
Don't double delete CommentsModel
Summary:
CommentsModel instances are owned by the engine.
They are fetched through a getter with a cache, so ownership has to stay
that way.
QuickItemsModel should not be deleting them.
Test Plan:
Got a valgrind log of the crash, which showed the issue
(see attached bug report)
Afterwards:
Opened systemsettings, opened comments dialog
Closed systemsettings
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27468
M +0 -1 src/qtquick/quickitemsmodel.cpp
https://commits.kde.org/knewstuff/5c7ee50bf900666efa44439a4f4a12ec5df986f9
--
You are receiving this mail because:
You are watching all bug changes.
