https://bugs.kde.org/show_bug.cgi?id=415155
David Edmundson <k...@davidedmundson.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/kwi | |n/3dbfa6a32545c9afd27bf8c1e | |86cba516b71d2a6 Resolution|--- |FIXED --- Comment #6 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit 3dbfa6a32545c9afd27bf8c1e86cba516b71d2a6 by David Edmundson. Committed on 12/02/2020 at 08:03. Pushed by davidedmundson into branch 'Plasma/5.18'. Return early if close button accepts input event Summary: Otherwise we close the effect whenever the close is pressed which is a behavioural change. That in turn leads to bigger bugs Test Plan: Ran effect Clicked on the "Whitespace" of the dash Clicked on the close Now matches desktopgrid code Reviewers: #kwin, zzag, ngraham Reviewed By: #kwin, zzag, ngraham Subscribers: ngraham, zzag, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D27333 M +4 -0 effects/presentwindows/presentwindows.cpp https://commits.kde.org/kwin/3dbfa6a32545c9afd27bf8c1e86cba516b71d2a6 -- You are receiving this mail because: You are watching all bug changes.