https://bugs.kde.org/show_bug.cgi?id=313892

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.18.0
      Latest Commit|                            |https://commits.kde.org/kin
                   |                            |focenter/4582053b7cac596e69
                   |                            |87a8ff460ffe7fb153155b
         Resolution|---                         |FIXED
             Status|REPORTED                    |RESOLVED

--- Comment #3 from Harald Sitter <sit...@kde.org> ---
Git commit 4582053b7cac596e6987a8ff460ffe7fb153155b by Harald Sitter.
Committed on 31/01/2020 at 15:11.
Pushed by sitter into branch 'Plasma/5.18'.

do not disable getifaddrs use because of sa_len availablility

Summary:
this fixes ipv6 support in nic listing. well, kinda.

the getifaddrs branch is the only one supporting ipv6 properly
so it seems silly to use the ioctl branch just because sa_len
is not available.
simply wrap around getnameinfo and either use sa_len or
determine the length based on the socket family (as seen on the
getifaddrs manpage). this way the branch compiles fine without
sa_len and is fine to use by just about all glibc systems thus
giving us ipv6 support on just about every glib system.
Related: bug 277208
FIXED-IN: 5.18.0

Test Plan: built on neon. shows ipv6 addresses

Reviewers: ngraham

Reviewed By: ngraham

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D26729

M  +25   -14   Modules/nics/nic.cpp

https://commits.kde.org/kinfocenter/4582053b7cac596e6987a8ff460ffe7fb153155b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to