https://bugs.kde.org/show_bug.cgi?id=385727
Kai Uwe Broulik <k...@privat.broulik.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |5.18.0
Resolution|DUPLICATE |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/bb573b83ace5a
| |8039b2d0f5192192496e7937308
--- Comment #2 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit bb573b83ace5a8039b2d0f5192192496e7937308 by Kai Uwe Broulik.
Committed on 31/01/2020 at 13:33.
Pushed by broulik into branch 'Plasma/5.18'.
[Task Manager] Remove strict URL handling
The code tried hard to ignore garbage URLs, as Qt is quite lenient, e.g.
QUrl("Garbage Url") is still valid.
There is no way to change the strictness of a QUrl after creation,
so the code would enforce it by doing QUrl strictUrl(inputUrl.toString(),
QUrl::StrictMode).
However, toString() defaults to PrettyDecoded which avoids percent-encoding and
keeps spaces
in tact which is not a valid thing to have in a strict URL.
Effectively, we want to ensure a URL is either a valid path to a local file,
or one of the special applications (for menu ids), or preferred for preferred
applications, like web browser,
FIXED-IN: 5.18.0
Differential Revision: https://phabricator.kde.org/D26941
M +20 -0 libtaskmanager/autotests/launchertasksmodeltest.cpp
M +7 -7 libtaskmanager/launchertasksmodel.cpp
M +17 -2 libtaskmanager/launchertasksmodel_p.h
https://commits.kde.org/plasma-workspace/bb573b83ace5a8039b2d0f5192192496e7937308
--
You are receiving this mail because:
You are watching all bug changes.
