https://bugs.kde.org/show_bug.cgi?id=414672

--- Comment #26 from Boudewijn Rempt <b...@valdyas.org> ---
Git commit 4ec9beafc1d40205b82aa50dc6f981cc10891d0f by Boudewijn Rempt, on
behalf of Agata Cacko.
Committed on 28/01/2020 at 09:09.
Pushed by rempt into branch 'krita/4.2'.

Initialize transform tool args when ending stroke

Before this commit, transform tool would get an
assert when switching to another tool without
any changes.
This commit removes trying to cancel the stroke
in the finishStrokeCallback() call
and initializes m_savedTransformArgs so the finishing
can happen as always.

WARNING: it probably isn't the "proper" solution
for this issue. It does work correctly, but it adds
an unnecessary undo step in the situation when cancelling
should be used instead of finishing the stroke
(for example when the user switches to transform tool
and then immediately to another tool without making any changes).
Related: bug 415625
(cherry picked from commit 8ef04427c4b8e63265ab4bb3456659cf4b0d39a4)

M  +25   -0   
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp

https://invent.kde.org/kde/krita/commit/4ec9beafc1d40205b82aa50dc6f981cc10891d0f

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to