https://bugs.kde.org/show_bug.cgi?id=410988
David Edmundson <k...@davidedmundson.co.uk> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit| |https://commits.kde.org/kde
| |plasma-addons/a51086867c0f0
| |f7e19b0dd2b9d59657542c46901
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit a51086867c0f0f7e19b0dd2b9d59657542c46901 by David Edmundson.
Committed on 15/01/2020 at 00:36.
Pushed by davidedmundson into branch 'master'.
[applets/calculator] Use Qt's in-built number formatting
Summary:
Gets rid of a load of code.
Correctly handles floating point issues.
Results are correct.
Potentially this inadvertedly introduces a behaviour change
of including group separators depending on locale. This could be
considered a good thing, but if it's problematic we can always add a
.replace() at the end of this line.
Test Plan:
62 * 1.3 = 80.6
100000000 * 5000000 = 5e+17
(with whatever the right number of zeroes is)
42 * 1.33333 = 6.6666665
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26676
M +2 -18 applets/calculator/package/contents/ui/calculator.qml
https://commits.kde.org/kdeplasma-addons/a51086867c0f0f7e19b0dd2b9d59657542c46901
--
You are receiving this mail because:
You are watching all bug changes.
