https://bugs.kde.org/show_bug.cgi?id=405030
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/sys
| |temsettings/4a82adba76df92d
| |19337e7c87b3c1121433cf6f8
Version Fixed In| |5.18
Status|CONFIRMED |RESOLVED
--- Comment #4 from Nate Graham <n...@kde.org> ---
Git commit 4a82adba76df92d19337e7c87b3c1121433cf6f8 by Nate Graham.
Committed on 04/01/2020 at 17:34.
Pushed by ngraham into branch 'master'.
Fix Ctrl+F shortcut conflict
Summary:
The base app was always setting Ctrl+F as a search shortcut, even when the
toolbar upon
which the search field lives was not visible. This caused the dreaded
"ambiguous shortcut"
dialog to appear. The patch fixes the issue by setting the shortcut only when
the toolbar
contains a search field, and unsetting it when the toolbar is hidden.
FIXED-IN: 5.18
Test Plan:
Hit {key Ctrl F} in both sidebar and icons view. In both cases, it focuses the
search
field.
Reviewers: #plasma, GB_2, apol
Reviewed By: apol
Subscribers: apol, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D26305
M +7 -1 app/SettingsBase.cpp
https://commits.kde.org/systemsettings/4a82adba76df92d19337e7c87b3c1121433cf6f8
--
You are receiving this mail because:
You are watching all bug changes.
