https://bugs.kde.org/show_bug.cgi?id=407376

--- Comment #1 from Julian Seward <jsew...@acm.org> ---
The patch causes the following fall-though warning, and the resulting
merged code does indeed look suspicious.  Is this intended?  If not
can you make a revised patch?

In file included from m_syswrap/syswrap-xen.c:49:
m_syswrap/syswrap-xen.c: In function ‘vgSysWrap_xen_sysctl_before’:
./pub_core_tooliface.h:50:10: warning: this statement may fall through
[-Wimplicit-fallthrough=]
   50 |       if (VG_(tdict).track_##fn)  \
      |          ^
m_syswrap/priv_types_n_macros.h:618:4: note: in expansion of macro ‘VG_TRACK’
  618 |    VG_TRACK( pre_mem_read, Vg_CoreSysCall, tid, zzname, zzaddr, zzlen)
      |    ^~~~~~~~
m_syswrap/syswrap-xen.c:600:7: note: in expansion of macro ‘PRE_MEM_READ’
  600 |       PRE_MEM_READ("XEN_SYSCTL_" #_sysctl " u." #_union "." #_field, \
      |       ^~~~~~~~~~~~
m_syswrap/syswrap-xen.c:604:7: note: in expansion of macro
‘__PRE_XEN_SYSCTL_READ’
  604 |       __PRE_XEN_SYSCTL_READ(_sysctl, _sysctl, _field)
      |       ^~~~~~~~~~~~~~~~~~~~~
m_syswrap/syswrap-xen.c:640:3: note: in expansion of macro
‘PRE_XEN_SYSCTL_READ’
  640 |   PRE_XEN_SYSCTL_READ(getdomaininfolist_0000000a, buffer);
      |   ^~~~~~~~~~~~~~~~~~~
m_syswrap/syswrap-xen.c:641:7: note: here
  641 |       case 0x00000010:
      |       ^~~~

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to