https://bugs.kde.org/show_bug.cgi?id=415263
Bug ID: 415263 Summary: Make it clear that ECMAddAppIcon's sources must be added in executable target directly Product: extra-cmake-modules Version: 5.64.0 Platform: MS Windows OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: general Assignee: ecm-bugs-n...@kde.org Reporter: aspotas...@gmail.com Target Milestone: --- SUMMARY Please make it clear in ECMAddAppIcon documentation that the resulting sources must be added in the executable target directly. ecm_add_app_icon doesn't work as expected at least on Windows if you add the sources in an intermediate STATIC or OBJECT library. I made this mistake in KTimeTracker, fixed it like this: http://commits.kde.org/ktimetracker/e712367404548bf200fb86e7ca2850f0c0785a4a Kate is still broken: https://bugs.kde.org/show_bug.cgi?id=415260 STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: 10 macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION -- You are receiving this mail because: You are watching all bug changes.