https://bugs.kde.org/show_bug.cgi?id=414929
Filip Fila <filipfila....@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.66
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/pla
| |sma-framework/e4e1613b0fe74
| |1aa6330810560bedf71b25e0e4c
--- Comment #2 from Filip Fila <filipfila....@gmail.com> ---
Git commit e4e1613b0fe741aa6330810560bedf71b25e0e4c by Filip Fila.
Committed on 11/12/2019 at 12:50.
Pushed by filipf into branch 'master'.
[PC3 ToolButton] Have the label take into account complementary color schemes
Summary:
We've ported the SDDM theme to PC3 and now have black labels in PC3 ToolButtons
(keyboard and session button).
The SDDM theme uses a complementary color scheme, which is something the PC2
ToolButton respects and turns the labels white.
Therefore I just copy pasted PC2's label color code to its PC3 counterpart.
FIXED-IN: 5.66
Test Plan:
```
import QtQuick 2.13
import org.kde.plasma.components 3.0 as PlasmaComponents
import org.kde.plasma.core 2.0 as PlasmaCore
PlasmaCore.ColorScope {
colorGroup: PlasmaCore.Theme.ComplementaryColorGroup
Rectangle {
height: 80
width: 100
color: "red"
PlasmaComponents.ToolButton{
anchors.fill: parent
text: "sup"
}
}
}
```
The label was white instead of black.
Reviewers: #plasma, ngraham, davidedmundson
Reviewed By: #plasma, ngraham, davidedmundson
Subscribers: mart, davidedmundson, fvogt, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D25699
M +8 -1 src/declarativeimports/plasmacomponents3/ToolButton.qml
https://commits.kde.org/plasma-framework/e4e1613b0fe741aa6330810560bedf71b25e0e4c
--
You are receiving this mail because:
You are watching all bug changes.
