https://bugs.kde.org/show_bug.cgi?id=413463
Marcin Gurtowski <halftough...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |halftough...@gmail.com
--- Comment #7 from Marcin Gurtowski <halftough...@gmail.com> ---
(In reply to Nate Graham from comment #6)
> Git commit 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6 by Nate Graham, on
> behalf of David Edmundson.
> Committed on 29/10/2019 at 19:39.
> Pushed by ngraham into branch 'Plasma/5.17'.
>
> [wallpapers/image] Randomise new batches of images in the slideshow
>
> Summary:
> There was a concious decision that when we add a new wallpaper we should
> append to the existing random order collection, rather than shuffle
> existing ones.
>
> The logic is fine but if we start with 0 wallpapers and then add 20 new
> ones we don't shuffle anything.
>
> This patch changes it so when a new batch of N wallpapers is added,
> those N are shuffled when appending to the existing sort order.
> FIXED-IN: 5.17.2
>
> Test Plan: qDebug + ran a few times
>
> Reviewers: #plasma, ngraham, davidre
>
> Reviewed By: ngraham, davidre
>
> Subscribers: davidre, plasma-devel
>
> Tags: #plasma
>
> Differential Revision: https://phabricator.kde.org/D24986
>
> M +1 -0 wallpapers/image/slidefiltermodel.cpp
>
> https://commits.kde.org/plasma-workspace/
> 9dca7d6cd44cbb16c6d7fb1aca5588760544b1d6
Has this been released yet? Because now on 5.17.4 after changing my wallpaper
directories I can definitively see patterns. Namely wallpapers from new
directory I added are all showed one after another, but old ones also continue
to appear in same order as they are structured in a directory.
What's more after booting up the first wallpaper is actually random, but after
that the next one will be second from the list, third one and so on.
--
You are receiving this mail because:
You are watching all bug changes.
