https://bugs.kde.org/show_bug.cgi?id=414498
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/kne
| |wstuff/dd5c9d461d868d4a6227
| |c4ed304ddbe22b64c583
--- Comment #2 from Nate Graham <n...@kde.org> ---
Git commit dd5c9d461d868d4a6227c4ed304ddbe22b64c583 by Nate Graham.
Committed on 29/11/2019 at 12:58.
Pushed by ngraham into branch 'master'.
Fix i18n syntax to avoid runtime errors
Summary:
Using `.arg()` in `i18n()` calls can lead to runtime errors such as the ones
shown in
https://bugs.kde.org/show_bug.cgi?id=414498. Let's port away from that.
Test Plan: QML GHNS dialog no longer has any i18n errors in strings
Reviewers: leinir, #plasma, #frameworks
Reviewed By: leinir
Subscribers: kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D25585
M +1 -1 src/attica/atticaprovider.cpp
M +1 -1 src/qtquick/qml/Dialog.qml
M +6 -6 src/qtquick/qml/EntryDetails.qml
M +1 -1 src/qtquick/qml/private/EntryCommentDelegate.qml
M +1 -1 src/qtquick/qml/private/EntryCommentsPage.qml
M +2 -2
src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M +2 -2 src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
M +1 -1 src/qtquick/quickitemsmodel.cpp
https://commits.kde.org/knewstuff/dd5c9d461d868d4a6227c4ed304ddbe22b64c583
--
You are receiving this mail because:
You are watching all bug changes.
