https://bugs.kde.org/show_bug.cgi?id=413087

David Edmundson <k...@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/419b9708ee9e3
                   |                            |6c4d5825ff6f58ca71f61d32d83
             Status|REPORTED                    |RESOLVED
   Version Fixed In|                            |5.17.3
         Resolution|---                         |FIXED

--- Comment #14 from David Edmundson <k...@davidedmundson.co.uk> ---
Git commit 419b9708ee9e36c4d5825ff6f58ca71f61d32d83 by David Edmundson.
Committed on 11/11/2019 at 16:40.
Pushed by davidedmundson into branch 'Plasma/5.17'.

Fix binding loop in lockscreen media controls

Summary:
When we load and position the Image the height is constrained, the width
is not. The image fillMode is set as  PreserveAspectFit so the width
will adjust to fit the aspect ratio,

Therefore we only want to set a fixed height on the sourceSize, it will
automatically match the resultant width.
FIXED-IN: 5.17.3

Test Plan:
I was unable to reproduce the state.
Patch is based on reading the code and docs

Reviewers: #plasma, broulik, ngraham

Reviewed By: #plasma, broulik, ngraham

Subscribers: broulik, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25252

M  +1    -1    lookandfeel/contents/lockscreen/MediaControls.qml

https://commits.kde.org/plasma-workspace/419b9708ee9e36c4d5825ff6f58ca71f61d32d83

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to