https://bugs.kde.org/show_bug.cgi?id=413940
--- Comment #2 from David Edmundson <k...@davidedmundson.co.uk> --- Git commit 35e5dc950e8fe2dfba46040495e21b17ed580dc1 by David Edmundson. Committed on 10/11/2019 at 17:29. Pushed by davidedmundson into branch 'master'. Remove pointless QDBusServiceWatcher Summary: KActivitymanagerd's ksmserver has a QDBusServiceWatcher in order to recreate a QDBusInterface when the service goes away. There is no need to do this, a call to a given method to a given service will work regardless, dispatching to the correct client is all internal to dbus-daemon. QDBusAbstractInterface has it's own internal QDBusServiceWatcher anyway so we don't get any behavioural differences if we check isValid. This is worth fixing as this class is moved threads and we end up with newly created children in a mess. Test Plan: Reviewers: #plasma, apol Reviewed By: apol Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D25205 M +3 -45 src/service/ksmserver/KSMServer.cpp M +0 -3 src/service/ksmserver/KSMServer_p.h https://commits.kde.org/kactivitymanagerd/35e5dc950e8fe2dfba46040495e21b17ed580dc1 -- You are receiving this mail because: You are watching all bug changes.
