https://bugs.kde.org/show_bug.cgi?id=389533
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Version Fixed In| |5.64
Latest Commit| |https://commits.kde.org/kir
| |igami/cae9d9cdbd716188030b1
| |20b14e342e0356d90f1
--- Comment #11 from Nate Graham <n...@kde.org> ---
Git commit cae9d9cdbd716188030b120b14e342e0356d90f1 by Nate Graham.
Committed on 31/10/2019 at 20:36.
Pushed by ngraham into branch 'master'.
Ensure that GlobalDrawer topContent always stays on top
Summary:
Right now, if you define `topContent` for your GlobalDrawer, it's added to the
scrollview
so it can actually scroll out of sight, making it not always on top.
This patch moves the `topContent` above the scrollview so it always stays on
top.
Test Plan:
Discover's GlobalDrawer toolbar no longer strangely scrolls out of view:
{F7680325}
No regressions in Discover when the view is not scrollable
No regressions that I could detect in Kirigami Gallery, though this probably
needs lots
more testing to ensure that nothing has exploded
FIXED-IN: 5.64
Reviewers: #kirigami, mart, apol, ahiemstra
Reviewed By: ahiemstra
Subscribers: plasma-devel
Tags: #kirigami
Differential Revision: https://phabricator.kde.org/D25019
M +196 -195 src/controls/GlobalDrawer.qml
https://commits.kde.org/kirigami/cae9d9cdbd716188030b120b14e342e0356d90f1
--
You are receiving this mail because:
You are watching all bug changes.
