https://bugs.kde.org/show_bug.cgi?id=413603

--- Comment #3 from Andreas Arnez <ar...@linux.ibm.com> ---
(In reply to Philippe Waroquiers from comment #2)
> Thanks for the patch.
> 
> Two small comments:
> * I am wondering if we should not allow comment lines starting with
>   0 or or spaces characters (like empty lines?) followed by # ?
I wondered about that, too.  Actually my first version allowed whitespace
before the comment marker.  But then I realized that callgrind_annotate doesn't
skip spaces at the beginning of a line in other cases, either.  Thus I adjusted
my patch to be consistent with the rest of the logic.
Do you know of a case where it would be necessary to allow whitespace before
the comment marker?

> * cg_annotate seems to suffer from the same bug.
Ah, good point.  I'll attach an updated patch with that change included.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to