https://bugs.kde.org/show_bug.cgi?id=412835

Dmitry Kazakov <dimul...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/kde/
                   |                            |krita/commit/ca2e423a9af4f5
                   |                            |c1f4691ab3e5f86d5fee61938b
         Resolution|---                         |FIXED

--- Comment #3 from Dmitry Kazakov <dimul...@gmail.com> ---
Git commit ca2e423a9af4f5c1f4691ab3e5f86d5fee61938b by Dmitry Kazakov.
Committed on 14/10/2019 at 14:45.
Pushed by dkazakov into branch 'master'.

Fix an assert when force-autosaving the image right during the stroke

When we make a clone of a shape layer, we must ensure that no updates
are initiated after cloning the image. We used to block updates at
the level of KisShapeLayerCanvas, but it works only when we save/clone
the image from the GUI thread. When we save it from the worker thread,
KoShapeManager queues the event into the GUI events queue, so an update
comes asynchronously.

To resolve this issue, the patch moves locking from KisShapeLayerCanvas
to KoShapeManager. We must ensure that there is no compressors nor queues
between the adding code and blocking code.

M  +12   -0    libs/flake/KoShapeManager.cpp
M  +11   -0    libs/flake/KoShapeManager.h
M  +2    -0    libs/flake/KoShapeManager_p.h
M  +2    -2    libs/ui/flake/kis_shape_layer.cc
M  +1    -12   libs/ui/flake/kis_shape_layer_canvas.cpp
M  +0    -4    libs/ui/flake/kis_shape_layer_canvas.h

https://invent.kde.org/kde/krita/commit/ca2e423a9af4f5c1f4691ab3e5f86d5fee61938b

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to