https://bugs.kde.org/show_bug.cgi?id=358240
Nate Graham <n...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|CONFIRMED |RESOLVED
Latest Commit| |https://commits.kde.org/pla
| |sma-workspace/acf91005b60c8
| |2f8381fb119f327f4d443c5b98d
--- Comment #5 from Nate Graham <n...@kde.org> ---
Git commit acf91005b60c82f8381fb119f327f4d443c5b98d by Nate Graham, on behalf
of Konrad Materka.
Committed on 10/10/2019 at 14:31.
Pushed by ngraham into branch 'Plasma/5.17'.
[XembedSNIProxy] Check size in each update()
Summary:
If needed, perform resize in each update().
Client window may be too big, it must be resized to a certain reasonable size.
Sometimes resizing in the constructor is not enough because it is too early and
the client window is not fully initialized. Even if client window is resized,
on first update it reverts back to original size (or just ignores the first
request - some kind of a race condition).
In addition, I applied some rules from:
https://community.kde.org/Policies/Kdelibs_Coding_Style
Test Plan:
I tested it using keepass2, now it shows better results (still not perfect).
Window is resized to 32x32, but icon is only 24x24 it top-left. Better than
273x273 with tiny dot in the corner. This is a workaround for unsolvable bug in
Mono - AFAIK Windows Forms are not longer maintained so it won't be fixed.
I tested this change with several other apps for regressions, no issues:
pidgin
liferea
hexchat
tuxguitar
xchat
keepassx
stardict
and other I don't remember now. No regressions.
Reviewers: davidedmundson, #plasma, #plasma_workspaces, broulik
Reviewed By: davidedmundson, #plasma, #plasma_workspaces
Subscribers: broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24529
M +42 -41 xembed-sni-proxy/sniproxy.cpp
M +1 -0 xembed-sni-proxy/sniproxy.h
https://commits.kde.org/plasma-workspace/acf91005b60c82f8381fb119f327f4d443c5b98d
--
You are receiving this mail because:
You are watching all bug changes.
