https://bugs.kde.org/show_bug.cgi?id=412283
Dmitry Kazakov <dimul...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Latest Commit| |https://invent.kde.org/kde/ | |krita/commit/227bd473709b13 | |32f2b52346bb651489b3b5478d Resolution|--- |FIXED --- Comment #6 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit 227bd473709b1332f2b52346bb651489b3b5478d by Dmitry Kazakov. Committed on 02/10/2019 at 19:41. Pushed by dkazakov into branch 'master'. Fix blending of layer styles with transparent pixels Overlay-like layer styles (overlay, inner shadow, inner glow and satin) seem to be applied in a complicated way: 1) Firstly the copy of the layer-stack projection is created 2) Then a copy of original layer alpha channel is extracted into a selection 3) Alpha channel of the layer itself is maxed-out to 1.0 4) The layer and all the layer overlay-like styles are merged into the projection 5) The the copy of the original projection from step 1) is copied onto the projection again using selection from step 2). This weird technique is used to ensure that color mixing happens exactly in full opacity, as if the colors would have no alpha-channel. M +4 -3 libs/image/kis_layer.cc M +3 -1 libs/image/kis_layer.h M +33 -1 libs/image/kis_layer_projection_plane.cpp M +8 -0 libs/image/kis_layer_projection_plane.h M +5 -0 libs/image/layerstyles/kis_layer_style_filter_projection_plane.cpp M +7 -0 libs/image/layerstyles/kis_layer_style_filter_projection_plane.h M +97 -64 libs/image/layerstyles/kis_layer_style_projection_plane.cpp M +2 -15 libs/image/layerstyles/kis_ls_overlay_filter.cpp M +0 -2 libs/image/layerstyles/kis_ls_overlay_filter.h M +9 -27 libs/image/layerstyles/kis_ls_satin_filter.cpp M +3 -2 libs/image/layerstyles/kis_ls_utils.h M +5 -0 libs/image/layerstyles/kis_multiple_projection.cpp M +2 -0 libs/image/layerstyles/kis_multiple_projection.h M +117 -0 libs/image/tests/kis_layer_style_projection_plane_test.cpp M +2 -0 libs/image/tests/kis_layer_style_projection_plane_test.h M +2 -1 libs/psd/psd.h https://invent.kde.org/kde/krita/commit/227bd473709b1332f2b52346bb651489b3b5478d -- You are receiving this mail because: You are watching all bug changes.