https://bugs.kde.org/show_bug.cgi?id=412530
--- Comment #2 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit d5279a0196bbaa08bb505a0db121a156a9d6d341 by Dmitry Kazakov. Committed on 08/10/2019 at 15:26. Pushed by dkazakov into branch 'krita/4.2'. Remove extra update when creating a new shape The update is emitted by KoShapeManager itself, so there is no reason to trigger it manually (it also eases thread-safety concerns, because after adding the shape to shape manager it is no longer safe to access it from the worker thread). M +0 -5 libs/ui/flake/kis_shape_controller.cpp https://invent.kde.org/kde/krita/commit/d5279a0196bbaa08bb505a0db121a156a9d6d341 --- Comment #3 from Dmitry Kazakov <dimul...@gmail.com> --- Git commit d4ee038d34b8a9e3b8fa2e53a09a2bb4da57f576 by Dmitry Kazakov. Committed on 08/10/2019 at 15:26. Pushed by dkazakov into branch 'krita/4.2'. Fix crash when using Pencil Tool with a tablet The patch basically makes KoPathShape::outline() cont-safe. Q_FOREACH doesn't support thread-safety, because it relies on copy-on-write. Every non-const access during Q_FOREACH will casue a detach, which is not safe in multithreaded environment. M +6 -4 libs/flake/KoPathShape.cpp https://invent.kde.org/kde/krita/commit/d4ee038d34b8a9e3b8fa2e53a09a2bb4da57f576 -- You are receiving this mail because: You are watching all bug changes.
