https://bugs.kde.org/show_bug.cgi?id=411634
David Barchiesi <da...@barchie.si> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Latest Commit| |https://commits.kde.org/lib
| |kgapi/2cbbdda752270cb505465
| |eb789938fbd0fa3ae51
Status|CONFIRMED |RESOLVED
--- Comment #1 from David Barchiesi <da...@barchie.si> ---
Git commit 2cbbdda752270cb505465eb789938fbd0fa3ae51 by David Barchiesi.
Committed on 01/10/2019 at 12:01.
Pushed by barchiesi into branch 'Applications/19.08'.
Fix null pointer dereference, keep FileModifyJob metadata and serialize with
options.
Summary:
This patch fixes a couple issues regarding FileAbstractUploadJob and
FileModifyJob:
- Fix null pointer dereference that was causing [[
https://bugs.kde.org/show_bug.cgi?id=411634 | BUG 411634 ]]. This was
introduced in {D22787} and in the affected block of code the mime-type must be
determined by LibKGAPI as no File metadata was provided.
- Pass File metadata from FileModifyJob ctor to FileAbstractUploadJob ctor.
This was letting KIO GDrive trigger the above bug when trying to specify the
modified files mime-type.
- Use provided serialization options also in FilePtr serialization during
building multipart request.
Reviewers: dvratil
Reviewed By: dvratil
Subscribers: #libkgapi, kde-pim
Tags: #kde_pim, #libkgapi
Differential Revision: https://phabricator.kde.org/D24301
M +1 -2 src/drive/fileabstractuploadjob.cpp
M +3 -1 src/drive/filemodifyjob.cpp
https://commits.kde.org/libkgapi/2cbbdda752270cb505465eb789938fbd0fa3ae51
--
You are receiving this mail because:
You are watching all bug changes.
