https://bugs.kde.org/show_bug.cgi?id=411223

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/60d6a3bdbcd44360e1c6ae
                   |                            |1c82239ecf6d60ded7
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |19.08.2

--- Comment #9 from Nate Graham <n...@kde.org> ---
Git commit 60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7 by Nate Graham.
Committed on 09/09/2019 at 13:17.
Pushed by ngraham into branch 'Applications/19.08'.

Fix ascending/descending choosers getting unchecked when re-selecting the same
sort order

Summary:
When you select the same sort order that's already selected, the
currently-checked
sort order description (the human-readable ascending/descending items) gets
unchecked
in `slotSortTriggered()` yet the ascending/descending items items only get
checked in
`slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one
gets
checked again.

This patch fixes the problem by not unchecking them in the first place.
FIXED-IN: 19.08.2

Test Plan:
1. Right-click > Sort By > Click the currently-selected sort order
2. Right-click > Sort By > See that the item for the current
ascending/descending setting has not been changed

Reviewers: elvisangelaccio, #dolphin

Reviewed By: elvisangelaccio, #dolphin

Subscribers: broulik, meven, kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D23412

M  +3    -2    src/views/dolphinviewactionhandler.cpp

https://commits.kde.org/dolphin/60d6a3bdbcd44360e1c6ae1c82239ecf6d60ded7

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to