https://bugs.kde.org/show_bug.cgi?id=344617
Elvis Angelaccio <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit| |https://commits.kde.org/dol | |phin/3a7586907ed834fb3c09d4 | |7e047da305a25374a2 Version Fixed In| |19.12.0 --- Comment #7 from Elvis Angelaccio <[email protected]> --- Git commit 3a7586907ed834fb3c09d47e047da305a25374a2 by Elvis Angelaccio, on behalf of Ismael Asensio. Committed on 01/09/2019 at 19:59. Pushed by elvisangelaccio into branch 'master'. [dolphin] Add an action to toggle the searchbar Summary: Make search action toggle the searchbar instead of just launching it. The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar. This behavior in inconsistent with other dolphin actions which toggle panels or tools. BEFORE: {F7256652} AFTER: {F7256862} FIXED-IN: 19.12.0 Closes T8473 Depends on D23075 Test Plan: - Enable the search mode: the searchbar appears and the toolbar button gets checked - Press the search button again, and it goes back to normal mode. - The search button state is coherent with the searchbox - Coherence is kept when changing to a split view or different tab - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it. Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio Reviewed By: ngraham, #vdg Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel Tags: #dolphin Maniphest Tasks: T8473 Differential Revision: https://phabricator.kde.org/D23232 M +26 -0 src/dolphinmainwindow.cpp M +3 -0 src/dolphinmainwindow.h M +3 -3 src/dolphinui.rc M +2 -0 src/dolphinviewcontainer.cpp M +12 -5 src/dolphinviewcontainer.h https://commits.kde.org/dolphin/3a7586907ed834fb3c09d47e047da305a25374a2 -- You are receiving this mail because: You are watching all bug changes.
