https://bugs.kde.org/show_bug.cgi?id=407979
Elvis Angelaccio <elvis.angelac...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version Fixed In| |19.11.80
Latest Commit| |https://commits.kde.org/dol
| |phin/ec1a0c2543a590dd5bd49c
| |3dfe27f77a27fcb05f
Resolution|--- |FIXED
Status|REOPENED |RESOLVED
--- Comment #4 from Elvis Angelaccio <elvis.angelac...@kde.org> ---
Git commit ec1a0c2543a590dd5bd49c3dfe27f77a27fcb05f by Elvis Angelaccio, on
behalf of Andrey Yashkin.
Committed on 11/08/2019 at 11:14.
Pushed by elvisangelaccio into branch 'master'.
Fix an issue with focus lost after closing terminal panel
Summary:
After leaving terminal with Ctrl-D or exit commands the input focus isn't set
back to the folder view.
The problem appears, because `TerminalPanel::isHiddenInVisibleWindow` returns
not what it supposed to return,
since when the terminal process exits, `m_terminal` is set to nullptr.
I moved unwanted checks from it inside `TerminalPanel::dockVisibilityChanged`
This change also exposes a crash in
`DolphinMainWindow::slotTerminalPanelVisibilityChanged()`,
which was previously working only by luck.
Now we check whether `m_activeViewContainer` is not null before using it.
FIXED-IN: 19.11.80
Test Plan:
1. Open Dolphin
2. Press F4 to open the terminal panel
3. Type exit<Enter> or press Ctrl-D
4. Check current focus widget
Reviewers: #dolphin
Subscribers: ngraham, elvisangelaccio, kfm-devel
Tags: #dolphin
Differential Revision: https://phabricator.kde.org/D22420
M +1 -1 src/dolphinmainwindow.cpp
M +2 -4 src/panels/terminal/terminalpanel.cpp
https://commits.kde.org/dolphin/ec1a0c2543a590dd5bd49c3dfe27f77a27fcb05f
--
You are receiving this mail because:
You are watching all bug changes.
