https://bugs.kde.org/show_bug.cgi?id=376905

Kai Uwe Broulik <k...@privat.broulik.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
      Latest Commit|https://commits.kde.org/kde |https://commits.kde.org/kde
                   |plasma-addons/cda996dfb011d |plasma-addons/eac0dbd5f1c0f
                   |50bcc1dcc68add42bdf24f175fc |1ba54bd9c9682da096d9c78db2a
         Resolution|---                         |FIXED

--- Comment #5 from Kai Uwe Broulik <k...@privat.broulik.de> ---
Git commit eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a by Kai Uwe Broulik.
Committed on 07/08/2019 at 06:53.
Pushed by broulik into branch 'Plasma/5.12'.

Remove colon (:) prefix when looking up dictionary word

The dictionary engine lets us specify a server and dictionary but we don't need
any of that,
and the engine can deal with just a word (these days?).
More importantly, the key inserted into the m_lockers map is without a colon
and since sourceRemoved is also called without it,
the wait condition is never met and we time out eventually.
The colon has been in there forever but from current dictionary engine code I
don't see why it would be neccessary.

CHANGELOG: Fixed dictionary runner not finding any definitions
FIXED-IN: 5.16.4

Differential Revision: https://phabricator.kde.org/D22814

(cherry picked from commit cda996dfb011d50bcc1dcc68add42bdf24f175fc)

M  +1    -1    runners/dictionary/dictionarymatchengine.cpp

https://commits.kde.org/kdeplasma-addons/eac0dbd5f1c0f1ba54bd9c9682da096d9c78db2a

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to