https://bugs.kde.org/show_bug.cgi?id=410622
Bug ID: 410622
Summary: Don't automatically create shortcut when Arguments are
malformed
Product: Snoretoast
Version: unspecified
Platform: Other
OS: MS Windows
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: vonr...@kde.org
Reporter: tho...@safing.io
CC: dan...@safing.io
Target Milestone: ---
SUMMARY
When the supplied Snoretoast-Arguments are malformed (because of an error in
the supplying app) and the appID therefore can't be obtained, the default
shortcut is installed. Also if the -close argument is used without appID, the
shortcut is installed. For sure an app shouldn't supply malformed arguments,
but developers forget stuff and installing a shortcut is something someone
doesn't want to do unintentionaly.
I don't know how to fix this best, but I suggest heavily restricting the cases
when a shortcut is created without -install beeing called explicitly or forcing
the explicit usage of -install (without arguments) even for usage without an
own appID. Also checking the supplied arguments for unknown attributes or
unbalanced quotes before installing the shortcut would be great.
STEPS TO REPRODUCE
Some examples:
*) snoretoast.exe -t Hello -m World -b "1;2;3_missing_end_quote -appID
"com.example"
*) snoretoast.exe -close -id a //missing appID installs Shortcut
OBSERVED RESULT
A shortcut is installed and in most cases a error-message is thrown.
EXPECTED RESULT
An error-message is thrown and the app exits.
--
You are receiving this mail because:
You are watching all bug changes.
