https://bugs.kde.org/show_bug.cgi?id=410556
Bug ID: 410556
Summary: [PATCH] add support for BLKIO{MIN,OPT} and BLKALIGNOFF
ioctls
Product: valgrind
Version: unspecified
Platform: Debian unstable
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: jsew...@acm.org
Reporter: dankamong...@gmail.com
Target Milestone: ---
Created attachment 121919
--> https://bugs.kde.org/attachment.cgi?id=121919&action=edit
Patch to bring blk ioctls up to speed with 5.2.5
Valgrind as checked out from git://sourceware.org/git/valgrind.git (and forked
to
g...@github.com:dankamongmen/valgrind.git) is missing support for three Linux
block ioctl()s. This was discovered while developing Growlight
(https://github.com/dankamongmen/growlight/issues/8). Without this patch,
Valgrind gives a false warning following my BLKALIGNOFF call. With it, there is
no such warning.
STEPS TO REPRODUCE
1. Call one of the mentioned ioctl()s under Valgrind
2. Use the result
OBSERVED RESULT
==15964== Warning: noted but unhandled ioctl 0x127a with no size/direction
hints.
==15964== This could cause spurious value errors to appear.
==15964== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a
proper wrapper.
==15964== Thread 4:
==15964== Conditional jump or move depends on uninitialised value(s)
==15964== at 0x4D99883: ??? (in /lib/x86_64-linux-gnu/libblkid.so.1.1.0)
==15964== by 0x4D9A465: ??? (in /lib/x86_64-linux-gnu/libblkid.so.1.1.0)
==15964== by 0x4D99A88: ??? (in /lib/x86_64-linux-gnu/libblkid.so.1.1.0)
==15964== by 0x4D8817A: blkid_do_fullprobe (in
/lib/x86_64-linux-gnu/libblkid.so.1.1.0)
==15964== by 0x114E1E: probe_blkid_superblock (libblkid.c:127)
==15964== by 0x110CE0: rescan (growlight.c:1014)
==15964== by 0x110CE0: rescan (growlight.c:905)
==15964== by 0x1121C5: create_new_device_inner (growlight.c:1137)
==15964== by 0x1121C5: create_new_device (growlight.c:1179)
==15964== by 0x112445: lookup_device (growlight.c:1249)
==15964== by 0x112445: lookup_device (growlight.c:1201)
==15964== by 0x113C6C: scan_device (growlight.c:1381)
==15964== by 0x5215FA2: start_thread (pthread_create.c:486)
==15964== by 0x53284CE: clone (clone.S:95)
EXPECTED RESULT
Smooth sailing
SOFTWARE/OS VERSIONS
Linux: 5.2.5
ADDITIONAL INFORMATION
Please merge. I've contributed once before, an ioctl for CDROM_GET_CAPABILITY
back in 2012 (due to the same project, actually).
--
You are receiving this mail because:
You are watching all bug changes.
