https://bugs.kde.org/show_bug.cgi?id=408991

Wolfgang Bauer <wba...@tmo.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED
                 CC|                            |wba...@tmo.at
     Ever confirmed|0                           |1

--- Comment #3 from Wolfgang Bauer <wba...@tmo.at> ---
I had the same problem when comparing two folders, and I can confirm that
https://phabricator.kde.org/D22294 fixed it for me too.

But: the commit to the 1.8 branch is incomplete:
https://cgit.kde.org/kdiff3.git/commit/?h=1.8&id=804997e45675e1ea1e86559d11f118d73fca8ce0
It misses a (the most important?) part.

I had to add these lines (from master) to fix 1.8.1:
         if(memcmp(&buf1[0], &buf2[0], len) != 0)
         {
             bError = false;
+            fi1.close();
+            fi2.close();
             return bEqual;
         }
         sizeLeft -= len;
         //pp.setCurrent(double(fullSize-sizeLeft)/fullSize, false );
         pp.step();
     }
+    fi1.close();
+    fi2.close();

     // If the program really arrives here, then the files are really equal.
     bError = false;

Reopening therefore.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to