https://bugs.kde.org/show_bug.cgi?id=400462
--- Comment #2 from Stefan Brüns <stefan.bru...@rwth-aachen.de> --- Git commit dc5c7229bc4ff75506c34197da5450808c969efe by Stefan Brüns. Committed on 17/07/2019 at 22:33. Pushed by bruns into branch 'master'. Remove kde4 migration agent completely Summary: The migration agent is some quite weird mechanism: - it starts the KDE4 kwalletd - to do this, it asks DBus to start it - as the old kwalletd never shipped a service file, kwalletd5 ships a service file for kwalletd(4), hardcoding its likely path. - it merges the old wallets via DBus requests When the migration has finished, a flag is set in the config and on the next start, the migration agent is skipped. When the migration fails (e.g. because kwalletd(4) is not installed), the migration is attempted on each start. Shipping a a service file pointing to the old daemon also breaks autostart of kwalletd5 for old applications - kwalletd5 provides the kwalletd interface, but only if it has been started already. This leads to a race during startup. See D16520 - proper kwalletd dbus service file for the legacy name Reviewers: #frameworks, cfeck, ngraham, aacid Reviewed By: aacid Subscribers: aacid, lbeltrame, kde-frameworks-devel, damjang Tags: #frameworks Differential Revision: https://phabricator.kde.org/D21002 M +0 -10 src/runtime/kwalletd/CMakeLists.txt M +0 -1 src/runtime/kwalletd/kwalletd.h M +1 -4 src/runtime/kwalletd/main.cpp D +0 -265 src/runtime/kwalletd/migrationagent.cpp D +0 -59 src/runtime/kwalletd/migrationagent.h D +0 -108 src/runtime/kwalletd/migrationwizard.cpp D +0 -44 src/runtime/kwalletd/migrationwizard.h D +0 -122 src/runtime/kwalletd/migrationwizard1.ui D +0 -51 src/runtime/kwalletd/migrationwizard2.ui D +0 -6 src/runtime/kwalletd/org.kde.kwalletd.service https://commits.kde.org/kwallet/dc5c7229bc4ff75506c34197da5450808c969efe -- You are receiving this mail because: You are watching all bug changes.
