https://bugs.kde.org/show_bug.cgi?id=408847

--- Comment #11 from Matt Fagnani <matthew.fagn...@utoronto.ca> ---
I requested that David's patch in comment 5 be backported to Qt 5.12.4 in
Fedora 30 at https://bugzilla.redhat.com/show_bug.cgi?id=1723017

Jan Grulich added four patches to qt5-qtwayland-5.12.4-2 which didn't appear to
include that patch 
https://src.fedoraproject.org/rpms/qt5-qtwayland/c/287f373520b3c3864a822304fac2b2c2f358ac8a?branch=f30

I've seen the segmentation faults in wl_proxy_marshal_constructor about nine
times with qt5-qtwayland-5.12.4-2. Sometimes the desktop colors became
grayscale before the crash. plasmashell usually restarted, but I had to start
plasmashell from konsole at least three times. I tried to apply David's patch
to the Fedora qt5-qtwayland repo I cloned, but I got errors with applying part
of the patch as follows.
fedpkg --release f30 local
...
+ /usr/bin/cat
/programs/qt/qt5-qtwayland/qtwayland.git-f06a5acd63105b09e5e77de534e5389fdd1dcb20.patch
+ /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch
1 out of 4 hunks FAILED -- saving rejects to file
src/client/qwaylandwindow.cpp.rej
error: Bad exit status from /var/tmp/rpm-tmp.RzO7c4 (%prep)
    Bad exit status from /var/tmp/rpm-tmp.RzO7c4 (%prep)


RPM build errors:
Could not execute local: rpmbuild --define '_sourcedir
/programs/qt/qt5-qtwayland' --define '_specdir /programs/qt/qt5-qtwayland'
--define '_builddir /programs/qt/qt5-qtwayland' --define '_srcrpmdir
/programs/qt/qt5-qtwayland' --define '_rpmdir /programs/qt/qt5-qtwayland'
--define 'dist %{?distprefix}.fc30' --define 'fedora 30' --eval '%undefine
rhel' --define 'fc30 1' -ba /programs/qt/qt5-qtwayland/qt5-qtwayland.spec | tee
.build-5.12.4-5.fc30.log

The part of the patch with the error in src/client/qwaylandwindow.cpp.rej was
--- src/client/qwaylandwindow.cpp
+++ src/client/qwaylandwindow.cpp
@@ -201,6 +203,7 @@ void QWaylandWindow::initWindow()

 void QWaylandWindow::initializeWlSurface()
 {
+    QWriteLocker lock(&mSurfaceLock);
     init(mDisplay->createSurface(static_cast<QtWayland::wl_surface *>(this)));
 }

Could that patch be backported to Qt 5.12? Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to