https://bugs.kde.org/show_bug.cgi?id=378613

Méven Car <meve...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|CONFIRMED                   |RESOLVED
      Latest Commit|                            |https://commits.kde.org/dol
                   |                            |phin/e6c1b97d67f6b6c6d4ad93
                   |                            |5db14241b041b3fca4
   Version Fixed In|                            |19.08.0

--- Comment #13 from Méven Car <meve...@gmail.com> ---
Git commit e6c1b97d67f6b6c6d4ad935db14241b041b3fca4 by Méven Car.
Committed on 23/06/2019 at 14:38.
Pushed by meven into branch 'master'.

Allow dolphin to auto-play previewed media file, click on preview to play/pause
videos or audio

Summary:
It is based on D19844.

I did my best to avoid glitches hence the amount of code touched.

Retry after @pekkah D7539
Moved the setting to the information panel context menu, no more timer

Settings screenshot :
{F6700220}

This would mach the same feature in the open/save dialog (although not
equivalent)
{F6696456}
FIXED-IN: 19.08.0
GUI: New information panel context menu option

Test Plan:
Without auto play
  - in dolphin with the information panel opened, and the auto media play
feature is disabled (right on the information panel)
  - hover over media files
  - the behavior is the same as before the patch

With auto play
  - in dolphin with the information panel opened, and the auto media play
feature is enabled
  - hover over media files
  - media is played automatically
  - hover over another media file, the new media is previewed

Use audio or video file as media.

Reviewers: #dolphin, elvisangelaccio, ngraham

Reviewed By: #dolphin, elvisangelaccio, ngraham

Subscribers: ngraham, broulik, kfm-devel, pekkah

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D19782

M  +4    -0    src/panels/information/dolphin_informationpanelsettings.kcfg
M  +8    -0    src/panels/information/informationpanel.cpp
M  +27   -6    src/panels/information/informationpanelcontent.cpp
M  +7    -0    src/panels/information/informationpanelcontent.h
M  +35   -21   src/panels/information/phononwidget.cpp
M  +16   -4    src/panels/information/phononwidget.h

https://commits.kde.org/dolphin/e6c1b97d67f6b6c6d4ad935db14241b041b3fca4

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to